Get Bid Type For Adjustments Bug Fix #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsardo
approved these changes
May 10, 2023
gargcreation1992
pushed a commit
that referenced
this pull request
May 16, 2023
blueseasx
pushed a commit
to blueseasx/prebid-server
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue with
getBidTypeForAdjustments, which is used to determine what bid type should be used to get the relevant bid adjustment. This is necessary specifically for the case where the bid type on the request isVideo, but for bid adjustments we need to determine if that bid type isvideo-instreamorvideo-outstreamby looking at the Imp tied to a request.The issue here was I assumed that if the bid type was
video, that the imp would also have avideotype in it. But it turns outVideocould be nil in the imp, which lead to a nil dereference panic.So I just needed to add a nil check into this function, and added an extra unit test for coverage.