Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #5

Merged
merged 4 commits into from
Apr 28, 2019
Merged

Update #5

merged 4 commits into from
Apr 28, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Apr 27, 2019 •
edited
Loading

Closes #4.

I smoke-tested android-arm64 locally with Level/leveldown#625:

$ file prebuilds/android-arm64/node.napi.armv8.node
prebuilds/android-arm64/node.napi.armv8.node: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped, with debug_info

This was referenced Apr 27, 2019
Merged
Closed
@vweevers
Copy link
Member Author

Also closes #6 (tested locally with --tag-libc).

@vweevers
Copy link
Member Author

I'm gonna try to setup autobuilds, in the interest of learning something new :)

With a machine user (prebuild-ci per prebuild/prebuild-install#62), I'm thinking

@vweevers
Copy link
Member Author

image

:)

@vweevers vweevers changed the title Add new environment variables for prebuildify@3 Update Apr 28, 2019
@vweevers vweevers merged commit c91560b into master Apr 28, 2019
@vweevers vweevers deleted the update-for-prebuildify-4 branch April 28, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for prebuildify@3
2 participants
@vweevers @ralphtheninja