-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does prebuildify have its own headers and node.lib cache? #64
Comments
Lines 183 to 187 in c6e4368
|
I see, what about the need to explicitly set the |
I don't know if there's a practical difference between these options though (because Node-API has delivered on their promise of compatibility, and defining
The Linux behavior is as expected because setting |
I wasn't setting nodedir on windows. Maybe that's the reason? Windows nodejs installation by default doesn't come with headers. So it seems it requires headers and also this thing called node.lib. Not sure what that is. |
Yeah, that's it. It shouldn't be necessary to set |
I've been trying out
prebuildify
on Windows, and I noticed it has its own node headers and node.lib cache.For example:
Is the node-gyp cache. While
Is prebuildify's node cache.
Considering that many packages are using
node-gyp-install
as their install script, their cache is likely populated by node-gyp automatically, why is prebuildify then creating its own cache?I also noticed that node-gyp will automatically fill the target with the current node version. But prebuildify doesn't. Even when
node-gyp
was using 16.14.2, prebuildify defaulted to 18.0.0, I had to explicitly set the--target=16.14.2
when using prebuildify to ensure it was using the same.Furthermore on Linux, once I have
nodedir
set,prebuildify
doesn't put anything in/tmp/prebuildify
, it only does it on Windows.The text was updated successfully, but these errors were encountered: