Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate micro-simulations on interior boundaries of macro-domain decomposition #102

Open
mathiskelm opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mathiskelm
Copy link
Collaborator

Problem:
When using macro-domain decomposition each MPI rank is given a bounding box, which is passed to preCICE to obtain coordinates of coupled points contained therein. If such a coupled macro-point lies on the boundary between two bounding boxes it will be included in both and the Micro Manager currently creates a micro simulation for both duplicates of the macro-point and passes their output to preCICE.

  • preCICE interprets this as two contributions to the participant's solution and accumulates them, producing incorrect results.
  • duplicate micro simulations receive identical macro-data and with no/global adaptivity identical output, wasting computational effort
  • with local adaptivity the two micro-simulations may have different associated active simulations and produce different outputs (differences should be minor if similarity measure is not overly generous)

Suggestion:
The Micro Manager should eliminate duplicate micro simulations to save computational time and avoid incorrect data being received by the macro simulation.

@IshaanDesai IshaanDesai added bug Something isn't working good first issue Good for newcomers labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants