Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to find similarity tolerances automatically #103

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Fujikawas
Copy link

Currently the similarity distances are computed as max(similarity_distances)*coarsening_constant or max(similarity_distances)*coarsening_constant*refining_constant.
With #64, it requires less active micro-scale simulations per iteration, but sometimes much more iterations to converge when important micro-scale simulations are missed by the stricter similarity condition.

In this PR, the two similarity distances are located by looking for the max-gap in the 1D distance array which is ascending sorted.
The distances could be weighted by a factor which is the exponential function of the right end distance of each gap. The exponent could be constant or some varying value computed from convergence status.

With the tests, this method could locate the threshold values relatively well:
with different adaptivity constants, the runtime varied between 150s to more than 2400s. With this method it took respectively (power = 0,5) 206s and (power = 0,7) 163s.

In these tests only the runtime is compared, not the accuracy. Local adaptivity and serial run for micro-simulations are used.

ToDo:

  • compute the tolerances only one time in each iteration;
  • test with parallelized micro-scale
  • accuracy and convergence study

@IshaanDesai IshaanDesai added the new-feature Adding a new feature label May 17, 2024
@IshaanDesai IshaanDesai marked this pull request as draft June 3, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Adding a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants