Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elastic-tube-1d: Remove unnecessary read statement #232

Merged
merged 2 commits into from
Feb 1, 2022
Merged

elastic-tube-1d: Remove unnecessary read statement #232

merged 2 commits into from
Feb 1, 2022

Conversation

BenjaminRodenberg
Copy link
Member

Closes #231

@BenjaminRodenberg BenjaminRodenberg self-assigned this Jul 29, 2021
@BenjaminRodenberg BenjaminRodenberg changed the base branch from master to develop July 29, 2021 08:15
@MakisH
Copy link
Member

MakisH commented Jul 29, 2021

Could you please rename the PR to clearly refer to elastic-tube-1d and to what it is changing? It would be easier to parse the PR list in the future.

@BenjaminRodenberg BenjaminRodenberg changed the title Remove unnecessary statement elastic-tube-1d: Remove unnecessary read statement Jul 29, 2021
@MakisH
Copy link
Member

MakisH commented Jul 29, 2021

Rebasing on develop should fix the failing "Check links" workflow.

@BenjaminRodenberg
Copy link
Member Author

This PR implements the following approach from #231 (comment):

initialize
read
while(ongoing){
  solve
  write
  advance
  read
}

@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jul 30, 2021
Closed
@uekerman
Copy link
Member

Don't forget the changelog entry

@MakisH MakisH merged commit 9750de5 into precice:develop Feb 1, 2022
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

@KyleDavisSA KyleDavisSA Awaiting requested review from KyleDavisSA

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels
bug
Projects
None yet
Milestone
v202202.0
Development

Successfully merging this pull request may close these issues.

elastic-tube-1d: Unnecessary readBlockScalarData
3 participants
@BenjaminRodenberg @MakisH @uekerman