Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added solid solver based on the python bindings for Dune-Fem #274

Merged
merged 6 commits into from
Jun 10, 2022

Conversation

NiklasKotarsky
Copy link
Contributor

@NiklasKotarsky NiklasKotarsky commented Apr 28, 2022

New solid solver for the tutorial flow over heated plate. The solver uses Dune-fem's python bindings https://www.dune-project.org/sphinx/dune-fem/. Joint work with @uekerman and @dr-robertk. Code base inspired from https://github.com/PeterMeisrimel/asynch-WFR.

@uekerman
Copy link
Member

Thanks, @NiklasKotarsky 👍

Is this a duplication of #270 or an extension?
If you want to continue here, we should close the other one then.

@NiklasKotarsky
Copy link
Contributor Author

Ok, I have extended #270 to also include implicit coupling.

@MakisH
Copy link
Member

MakisH commented May 25, 2022

Thanks a lot for contributing! Not sure what the state of it is, but when you are ready for a review, please also include some documentation in the README.md of the parent folder. Please also extend the PR description with a few more details.

@NiklasKotarsky NiklasKotarsky changed the title dune-fem python solver added for the tutorial flow over heated plate added solid solver based on the python bindings for Dune-Fem May 31, 2022
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for adding this 👍

@uekerman
Copy link
Member

uekerman commented Jun 9, 2022

Also added the "adapter" to the website: precice/precice.github.io#173

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tutorial and it seems to work 👍 Only problem for me was that I really needed to use a virtual environment, something our users may not be familiar with as well.

Note that one needs to make pyprecice and scipy available as well, e.g., with installing them again in the environment. By default, we ask users to install with pip3 install --user.

Thanks a lot for the contribution, this tutorial is shaping up really nicely! 😄

flow-over-heated-plate/README.md Outdated Show resolved Hide resolved
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@uekerman uekerman merged commit e5fffa6 into precice:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants