-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added solid solver based on the python bindings for Dune-Fem #274
Conversation
Thanks, @NiklasKotarsky 👍 Is this a duplication of #270 or an extension? |
Ok, I have extended #270 to also include implicit coupling. |
Thanks a lot for contributing! Not sure what the state of it is, but when you are ready for a review, please also include some documentation in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for adding this 👍
Also added the "adapter" to the website: precice/precice.github.io#173 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the tutorial and it seems to work 👍 Only problem for me was that I really needed to use a virtual environment, something our users may not be familiar with as well.
Note that one needs to make pyprecice
and scipy
available as well, e.g., with installing them again in the environment. By default, we ask users to install with pip3 install --user
.
Thanks a lot for the contribution, this tutorial is shaping up really nicely! 😄
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
New solid solver for the tutorial flow over heated plate. The solver uses Dune-fem's python bindings https://www.dune-project.org/sphinx/dune-fem/. Joint work with @uekerman and @dr-robertk. Code base inspired from https://github.com/PeterMeisrimel/asynch-WFR.