Update elastic-tube-3d images #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously we justified the disagreement in the results by stating that the FEniCS structural solver is linear, and we use nonlinear geometry in CalculiX. This is still the case, so the sudden agreement is puzzling. But in principle agreement of results is a good thing. |
IshaanDesai
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the images used in the elastic-tube-3d tutorial, based on:
The OpenFOAM-FEniCS case seems to be producing significantly different results than before. @BenjaminRodenberg @IshaanDesai is this something you would expect? They definitely look in better agreement now with OpenFOAM-CalculiX.
The surface plot is OpenFOAM-FEniCS.
precice-Solid-FEniCS-watchpoint-Tube-Midpoint.log
precice-Solid-CalculiX-watchpoint-Tube-Midpoint.log