Update client docs with new endpoint source #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Dec 21, 2023
docs/reference/python_client.md
Outdated
| endpoint_url = f"https://api.app.predibase.com/v1/llms/{llm_deployment_name}" | ||
| # You can get your Predibase API token by going to Settings > My Profile > Generate API Token | ||
| # You can get your Predibase Tenant short code by going to Settings > My Profile > Overview > Tenant ID | ||
| endpoint_url = f"https://serving.app.predibase.com/{predibase_tenant_short_code}/deployments/v2/llms/{llm_deployment_name}/" |
There was a problem hiding this comment.
Do we need trailing slash?
There was a problem hiding this comment.
we can with or without, but we no longer need it
There was a problem hiding this comment.
for record-keeping, using /generate will not work in the client because the API will not return a list.
tgaddair
approved these changes
Dec 21, 2023
tgaddair
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.