Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✈️ fix for #270 #272

Merged
merged 9 commits into from
Nov 20, 2023
Merged

✈️ fix for #270 #272

merged 9 commits into from
Nov 20, 2023

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Nov 10, 2023

This PR fixes #270 - by adding the customdata property to the to-be-checked hf_data list

TODO:

  • write tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (88b0585) 96.53% compared to head (8a7e34c) 96.46%.
Report is 1 commits behind head on main.

Files Patch % Lines
...tly_resampler/figure_resampler/figure_resampler.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   96.53%   96.46%   -0.08%     
==========================================
  Files          14       14              
  Lines        1127     1130       +3     
==========================================
+ Hits         1088     1090       +2     
- Misses         39       40       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasvdd jonasvdd requested a review from jvdd November 16, 2023 15:21
* ✈️ 🇧🇪 fix for #259

* 💨 linting

* 💨 adding autosize support

* ✨ updating action versions

* 🙈 skip dtype test on window

* 🙏 skip test
@jonasvdd jonasvdd added the bug Something isn't working label Nov 20, 2023
@jonasvdd jonasvdd self-assigned this Nov 20, 2023
@jonasvdd jonasvdd merged commit 741da5d into main Nov 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hover data does not match the displayed resampled point in scatter plot
3 participants