Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixi add pip results in wrong matchspec and fails during install #1878

Closed
2 tasks done
vigneshmanick opened this issue Aug 21, 2024 · 1 comment · Fixed by #1885
Closed
2 tasks done

pixi add pip results in wrong matchspec and fails during install #1878

vigneshmanick opened this issue Aug 21, 2024 · 1 comment · Fixed by #1885
Labels
🐞 bug Something isn't working

Comments

@vigneshmanick
Copy link
Contributor

vigneshmanick commented Aug 21, 2024

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

pixi init --format pyproject  test-proj
cd test-proj
pixi add pip
pixi install
# Errors out because the versions of pip is not right
[project]
dependencies = []
name = "test-proj"
requires-python = ">= 3.11"
version = "0.1.0"

[build-system]
build-backend = "hatchling.build"
requires = ["hatchling"]

[tool.pixi.project]
channels = ["conda-forge"]
platforms = ["linux-64"]

[tool.pixi.pypi-dependencies]
test-proj = { path = ".", editable = true }

[tool.pixi.tasks]

[tool.pixi.dependencies]
pip = ">=24.2,<24.1"

Issue description

Not sure if it's just with my machine or genreally the case , i just tested with a dummy project just to be sure and can reproduce it.

Pixi add seems to mix up the min and max versions of the added dependencies and fails install as a result. Currently i am facing this with just adding pip as a dependency.

Expected behavior

should be

[tool.pixi.dependencies]
pip = ">=24.1,<24.2"

NOTE: I have set pinning-strategy to minor

Edit: I am pretty sure this has to do with the pinning-strategy set to minor, when it's set to semver, the issue doesn't occur since the upper bounds are much higher.

@vigneshmanick vigneshmanick added the 🐞 bug Something isn't working label Aug 21, 2024
@vigneshmanick vigneshmanick changed the title pixi add pip gives out the wrong min max and fails during install pixi add pip results in wrong matchspec and fails during install Aug 21, 2024
@baszalmstra
Copy link
Contributor

Thanks for reporting that was indeed a bug! It should be fixed with #1885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants