Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell-hook command #672

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Jan 16, 2024

closes #410

This is a hidden command - let me know where should we document this!

@orhun
Copy link
Contributor Author

orhun commented Jan 16, 2024

Hmm, I'm think we can also add tests for this if needed.

@ruben-arts
Copy link
Contributor

A test would be much appreciated! I'm not sure we need to hide it from the help.

@wolfv
Copy link
Member

wolfv commented Jan 16, 2024

Looks good!

@orhun
Copy link
Contributor Author

orhun commented Jan 16, 2024

A test would be much appreciated!

Added in 5c65ccf

I'm not sure we need to hide it from the help.

Added about text in b86a979 in case we decide to make it visible in the future.

@ruben-arts
Copy link
Contributor

He it would be awesome to have this added to the examples/docker-build project.

Here it would be nice to install something from a pixi.toml (pixi itself might be a weird example).
Then write the pixi shell-hook > pixi-activation.sh.
Then throw away the initial install image and only copy the .sh file and the environment to be able to activate it in the docker image without having pixi in the docker image.

I guess you can use docker multistage for this

src/cli/shell_hook.rs Outdated Show resolved Hide resolved
@wolfv
Copy link
Member

wolfv commented Jan 17, 2024

I think we also need to get rid of the shebang because that wouldn't work on a powershlel script on Linux etc

@orhun
Copy link
Contributor Author

orhun commented Jan 17, 2024

Removed shebang in 9591a1e

@wolfv wolfv merged commit 73c5bf1 into prefix-dev:main Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement shell-hook
4 participants