Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a wheel cache #79

Closed
Tracked by #32
tdejager opened this issue Nov 16, 2023 · 6 comments
Closed
Tracked by #32

Create a wheel cache #79

tdejager opened this issue Nov 16, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@tdejager
Copy link
Contributor

tdejager commented Nov 16, 2023

So, it would be nice to have cache of built wheel files, once we built them using #32 this way we can re-use them over solves or platforms when using with pixi.

So @baszalmstra and I discussed using cacache-rs for this.

@tdejager tdejager added the enhancement New feature or request label Nov 16, 2023
@cnpryer
Copy link

cnpryer commented Nov 20, 2023

Would this also support #64?

@tdejager
Copy link
Contributor Author

@cnpryer Sure! Although the downloaded artifacts are already cached :) We could also start using cacache-rs for that thats what you mean?

@cnpryer
Copy link

cnpryer commented Nov 20, 2023

We could also start using cacache-rs for that thats what you mean?

Yea I was thinking through the ways it could be implemented.

@baszalmstra
Copy link
Contributor

@tdejager Do we want to store the unpacked wheel in the cache? (Through an indirection).

So we have an entry: rip::wheel::<integrity> that contains metadata that describes the files in the .whl and their integrities. Then we can use the same thing for regular wheels as well.

@tdejager
Copy link
Contributor Author

tdejager commented Nov 27, 2023

So the plan for now is:

  • Create a disk cache using cacache.
  • Store metadata for the hashed sdist.
  • Store the wheel by hash and store the hash in the metadata for the sdist.

After which we should add functionality to:

  • Check if we have already built the wheel when building an sdist.
  • Install wheels from cache and package_db

@tdejager
Copy link
Contributor Author

tdejager commented Dec 5, 2023

Implemented in #107 and #111

@tdejager tdejager closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants