-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add os.getnumcpus
function to get number of logical CPU cores.
#2241
Merged
+121
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
force-pushed
the
os-getnumcpus
branch
2 times, most recently
from
September 1, 2024 17:16
41f984f
to
3c1c85d
Compare
KyrietS
requested changes
Sep 1, 2024
tritao
force-pushed
the
os-getnumcpus
branch
2 times, most recently
from
September 1, 2024 17:35
aab54ae
to
2e593cf
Compare
Thanks for the super fast review, addressed the nits 👍 |
Jarod42
reviewed
Sep 1, 2024
Jarod42
reviewed
Sep 2, 2024
tritao
force-pushed
the
os-getnumcpus
branch
2 times, most recently
from
September 2, 2024 10:36
755b782
to
a4a73df
Compare
Updated with new round of reviews. |
Jarod42
approved these changes
Sep 2, 2024
nickclark2016
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty minor, fix and I'll merge.
tritao
force-pushed
the
os-getnumcpus
branch
from
September 5, 2024 14:15
a4a73df
to
511418b
Compare
Updated again. |
Thanks for this! Previously, I had to use this code for my projects:
Now I can use the function you have added instead. |
KyrietS
approved these changes
Sep 11, 2024
nickclark2016
approved these changes
Sep 11, 2024
Open
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
os.getnumcpus
API to get the number of logical CPU cores.This can be helpful to know the parameter to pass to
make -j
flag, which in my case I need to generate correct VS Code tasks files.Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)