Adds new method to check for existence of credit notes #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenmaster
requested changes
May 19, 2023
There was a problem hiding this comment.
You only implemented this new optimized solution for the credit receipt flow. Please add it as well to the credit note flow as it would also benefit from this change
(Side note: you actually mentioned credit notes in the title of your PR but only changed credit recepits :) )
froque
force-pushed
the
425-checkcreditreceipt-is-io-intensive-with-no-need
branch
from
b825975
to
f9d4b2b
Compare
|
I forgot about the two different types of credit once again. that explains the missing for Portugal. PR updated |
…eipts This new method performs better, without needing to fetch a lot of data from disk in Postgresql.
froque
force-pushed
the
425-checkcreditreceipt-is-io-intensive-with-no-need
branch
from
f9d4b2b
to
ffb4b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method performs better, without needing to fetch a lot of data from disk in Postgresql.
There is an open question for Portugal, where this method does not exist, if it should exist or if the method should not exist for all countries.
fixes #425