Correct simple invoice amount limits #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2023 17:45
The used limits for simple invoice amounts for non business customers are incorrect for PT and AD This updates the amounts to the following values - 3000€ for PT - 40000€ for AD This also makes all flows use the same exception to signal that the amount is above the limit instead of each module defining its own generic simple invoice exception that is only used in this scenario
As imposed by law Also other small adjustments to tests and naming
Vasco-F
requested changes
Jul 11, 2023
.../java/com/premiumminds/billy/portugal/services/builders/impl/PTSimpleInvoiceBuilderImpl.java
Outdated
Show resolved
Hide resolved
...ain/java/com/premiumminds/billy/spain/services/builders/impl/ESSimpleInvoiceBuilderImpl.java
Outdated
Show resolved
Hide resolved
limit The simple invoice limits were mixed up. Should be 3000€ for ES and 1000€ for PT Dropped the invoice limit check for PT since that limit applies only to businesses and not all customers.
Vasco-F
approved these changes
Jul 12, 2023
froque
reviewed
Jul 12, 2023
...n/java/com/premiumminds/billy/andorra/services/builders/impl/ADSimpleInvoiceBuilderImpl.java
Outdated
Show resolved
Hide resolved
...rra/src/main/java/com/premiumminds/billy/andorra/exceptions/BillySimpleInvoiceException.java
Outdated
Show resolved
Hide resolved
invoice limits a config value
froque
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.