Removes @Inheritance from JPABaseEntity #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Hibernate warning: HHH000503: A class should not be annotated with both @Inheritance and @MappedSuperclass. @Inheritance will be ignored for: com.premiumminds.billy.core.persistence.entities.jpa.JPABaseEntity https://hibernate.atlassian.net/browse/HHH-13217 Don't throw exception if both @MappedSuperclass and @Inheritance are used
thenmaster
approved these changes
Jan 9, 2024
froque
deleted the
164-a-class-should-not-be-annotated-with-both-inheritance-and-mappedsuperclass
branch
thenmaster
pushed a commit
that referenced
this pull request
Jan 10, 2024
country modules This annotation was previously being set in JPABaseEntity but was removed in #498. This change resulted in a change to the schema required by the application that was only detected when a client application was updated since the schema used during tests is generated from the code meaning it is always correct. Adding the annotation back to all entities that are extended in the various submodules resolves this problem since hibernate once again knows how the schema of the application should be assembled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Hibernate warning:
HHH000503: A class should not be annotated with both @Inheritance and @MappedSuperclass. @Inheritance will be ignored for: com.premiumminds.billy.core.persistence.entities.jpa.JPABaseEntity
https://hibernate.atlassian.net/browse/HHH-13217
Don't throw exception if both @MappedSuperclass and @Inheritance are used
Fixes #164