Update ValidURIs function to accept UDS #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prep
reviewed
Sep 23, 2022
|
Thanks for the review. I have updated the PR. |
| @@ -95,12 +95,16 @@ func ValidURIs(uris []string) error { | |||
| } | |||
|
|
|||
| for _, uri := range uris { | |||
| hostport, _, err := parseURI(uri) | |||
| address, uriType, err := parseURI(uri) | |||
There was a problem hiding this comment.
Brilliant! This should be merged
There was a problem hiding this comment.
Fine! But only because you said so, not because @cooldarkdryplace made the PR 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ValidURIs check to handle UDS addresses differently from TCP socket addresses.
One distinct difference is that UDS does not require a port number. I am adding a test for this function.