Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use load-config script #567

Merged
merged 4 commits into from
Jul 14, 2021
Merged

fix: use load-config script #567

merged 4 commits into from
Jul 14, 2021

Conversation

prescottprue
Copy link
Owner

@prescottprue prescottprue commented Jul 13, 2021

Description

  • Load config using a node script instead of inline bash (was causing a syntax error with certain configs)

Important Code

Additional Information

Relevant Issues

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #567 (1e25566) into master (6206adf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files          28       28           
  Lines        1328     1328           
  Branches      182      182           
=======================================
  Hits          864      864           
  Misses        389      389           
  Partials       75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6206adf...1e25566. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 14, 2021



Test summary

33 0 5 0Flakiness 3


Run details

Project fireadmin
Status Passed
Commit 2b04732 ℹ️
Started Jul 14, 2021 1:15 AM
Ended Jul 14, 2021 1:19 AM
Duration 03:31 💡
OS Linux Ubuntu - 20.04
Browser Chrome 91

View run in Cypress Dashboard ➡️


Flakiness

Project/ActionRunner.spec.js Flakiness
1 Project - Actions Page > Environment Locking > locked env is disabled as a source
ProjectsPage.spec.js Flakiness
1 Projects Page > Delete Project > allows project to be deleted by project owner
ActionTemplates/ActionTemplatesPage.spec.js Flakiness
1 Actions Template Page > When Authenticated > Allows user to create a new template

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@prescottprue prescottprue merged commit 75aca19 into master Jul 14, 2021
@prescottprue prescottprue deleted the load-config-script branch July 14, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant