Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup fail (with analytics) #164

Closed
doublejosh opened this issue Nov 15, 2019 · 2 comments
Closed

Setup fail (with analytics) #164

doublejosh opened this issue Nov 15, 2019 · 2 comments

Comments

@doublejosh
Copy link

doublejosh commented Nov 15, 2019

The app cannot be compiled or run after setup if choosing to include analytics. Two issues thus far...

./src/utils/analytics.js
Attempted import error: 'segmentId' is not exported from 'config' (imported as 'config').
./src/utils/analytics.js
  Line 50:28:  'eventName' is not defined                         no-undef
  Line 52:7:   'GOOGLE_EVENT_TYPES_BY_EVENT_NAME' is not defined  no-undef
  Line 52:40:  'eventName' is not defined                         no-undef
  Line 52:54:  'eventName' is not defined                         no-undef
  Line 55:47:  'eventName' is not defined                         no-undef

Possible Solutions
Add a segment ID input to the init process.

The analytics constants file doesn't exist, it should be created here...
/src/constants/analytics.js

This line may be incorrect...
src/utils/analytics.js

export function triggerAnalyticsEvent(eventNameKey, eventData) {

...I believe eventNameKey should be eventName

This variable GOOGLE_EVENT_TYPES_BY_EVENT_NAME may need to be the same as the import ANALYTICS_EVENT_NAMES

@doublejosh doublejosh changed the title Setup fail (Analytics) Setup fail (with analytics) Nov 15, 2019
@prescottprue
Copy link
Owner

Oh man that is a silly one, thanks for reporting!

prescottprue pushed a commit that referenced this issue Nov 15, 2019
* fix(app): fix bad reference in analytics util - #164
* chore(core): update dependencies including chalk + babel
@prescottprue prescottprue mentioned this issue Nov 15, 2019
2 tasks
prescottprue added a commit that referenced this issue Nov 15, 2019
* fix(app): fix bad reference in analytics util - #164
* fix(app): remove lint from analytics util
* chore(core): update dependencies including chalk + babel
@prescottprue
Copy link
Owner

Fixed in v4.0.1 release, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants