Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update the following components: LoadableComponent #186

Closed
przmv opened this issue Mar 20, 2020 · 2 comments
Closed

Please update the following components: LoadableComponent #186

przmv opened this issue Mar 20, 2020 · 2 comments

Comments

@przmv
Copy link
Contributor

przmv commented Mar 20, 2020

Describe the bug

I get warning messages: “Warning: componentWillMount has been renamed” in my DevTools console.

To Reproduce
Steps to reproduce the behavior:

  1. Generate the app and start the dev server: yo react-firebase && npm start
  2. Sign-up and login
  3. Go to http://localhost:3000/projects
  4. Open Browser's DevTools console and see error:
Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: LoadableComponent

Expected behavior/code
No warning message.
@prescottprue
Copy link
Owner

prescottprue commented Mar 20, 2020 •
edited
Loading

Thanks for noting this, I will look into it. I believe it may be due to react-loadable.

I'm planning on implementing React.lazy where possible to remove dependence on it

prescottprue pushed a commit that referenced this issue Mar 20, 2020
feat(app): replace react-loadable with React.lazy - #186
1d4e0da 
* feat(app): update reactfire to v2.0.2 (out of pre-release)
* feat(app): update dev dependencies including cypress + cypress-firebase
@prescottprue prescottprue mentioned this issue Mar 20, 2020
Merged
2 tasks
prescottprue added a commit that referenced this issue Mar 20, 2020
@prescottprue
feat(app): replace react-loadable with React.lazy - #186 (#188)
338a802 
* feat(app): update reactfire to v2.0.2 (out of pre-release)
* feat(app): update dev dependencies including cypress + cypress-firebase
@prescottprue prescottprue mentioned this issue Mar 20, 2020
Merged
2 tasks
prescottprue added a commit that referenced this issue Mar 22, 2020
@prescottprue
v5.2.0 (#189)
63fd003 
* feat(app): replace react-loadable with `React.lazy` and `React.Suspense` - #186 (#188)
* fix(app): set firestore rules version to v2 - #185
* feat(app): update reactfire to v2.0.2 (out of pre-release)
* feat(app): update dev dependencies including cypress + cypress-firebase
* feat(app): add support for emulators in app and tests
* fix(app): update README to include notes about using emulators
* chore(deps): update semver to 7.1.3
* chore(deps): update prettier to v2.0.0
@prescottprue
Copy link
Owner

Thanks for reporting! Fixed in v5.2.0 release by switching to React.lazy and React.Suspense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@przmv @prescottprue