Error: Cannot find module './factoryWithThrowingShims' from '/app/node_modules/react-redux-firebase/dist' #128

karltaylor · 2017-05-10T19:14:36Z

Just did a fresh npm install on a new project and imported into my project and got

Error: Cannot find module './factoryWithThrowingShims' from '/app/node_modules/react-redux-firebase/dist'
    at /app/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21
    at load (/app/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/app/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /app/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:123:15)

prescottprue · 2017-05-10T19:29:50Z

What version did you npm install? You can check using npm ls react-redux-firebase (can you copy the output here or attach a screenshot)?

Also, what did you specify in your package.json for version or react-redux-firebase? What is your loader config look like (assuming you are using Webpack)?

Seems like it might be a loader issue since react-redux-firebase does not use async that I am aware of.

danibrear · 2017-05-11T22:19:31Z

getting this with
react-redux-firebase@1.4.0-rc.2
Although i'm also using: react@16.0.0-alpha.6

doing a little bit of digging it seems like it might be something to do with PropTypes being abstracted from the react library? Just a thought, haven't dug into the code too much.

prescottprue · 2017-05-11T22:26:32Z

Interesting thought @DavidBrear.

Have you tried older versions of react-redux-firebase (i.e. v1.3.4 or v1.4.0-rc.1)? Usage of prop-types within react-redux-firebase didn't start until v1.4.0-rc.2.

Have you tried a v15 version of react like 15.5.4 (latest) or v15.3.2 (used in all of the react-redux-firebase examples)?

My guess is still that it is due to webpack loader parsing. If a reproduction repo can be provided or webpack loader config is provided, it would be easier to know.

danibrear · 2017-05-12T11:49:55Z

Moving to v1.4.0-rc.1 fixed it. I've pulled down the source to see if I could make a PR to fix in rc.2 will try to get to it today.

prescottprue · 2017-05-12T18:44:26Z

@DavidBrear That would be great. This is one of the last things to get ironed out before the v1.4.0 release.

If we can't get it ironed out, we might have to go back to not using prop-types (which will throw deprecation warnings for some)

* Switched back to importing PropTypes from react due to (#128) * Roadmap updated with population features coming in `v1.5.0`

prescottprue · 2017-05-16T19:04:35Z

v1.4.0-rc.3 has been released. It includes switching back to importing PropTypes from react instead of prop-types (which has been moved to 1.5.0 within the roadmap).

@DavidBrear This means you should be able to use v1.4.0-rc.3, let me know if you get a chance to check it out. If so, planning on releasing v1.4.0 from rc.3.

Note: Issue remaining open until this is out of pre-release

prescottprue · 2017-05-17T23:03:09Z

v1.4.0 has been released so this is now out of pre-release. prop-types usage has been moved out to v1.5.0.

miketamis · 2017-05-24T04:55:23Z

Im still getting this error:

Building JavaScript bundle: error
Unable to resolve module `./factoryWithThrowingShims` from `/node_modules/react-redux-firebase/dist/react-redux-firebase.js`: Directory /node_modules/react-redux-firebase/dist/factoryWithThrowingShims doesn't exist

my version react-redux-firebase@1.5.0-alpha

prescottprue · 2017-05-24T06:31:01Z

@miketamis What is your webpack config? Are you using webpack 1 or 2?

Can anyone provide a repo where this can be reproduced?

prescottprue · 2017-05-24T07:36:04Z

Another theory:

It may have to due with prop-types needing to be set as an external in the webpack config. This would make it so that prop-types points to the one required by your project instead of being included in the bundle (means that prop-types will instead of a peer dependency instead of dependency).

Again, can only be tested/confirmed if a repro is provided.

ricardokdz · 2017-05-24T23:02:45Z

i have the same problem using react and react native

miketamis · 2017-05-24T23:26:46Z

Yeap this error for me was with Expo. I fix it by putting the proptype repo into the react-redux-firebase dist folder in node_modules (obviously not a good fix)

prescottprue · 2017-05-25T01:05:38Z

@ricardokdz and @miketamis ok, going to try some stuff and hopefully get a alpha.2 version out soon that address this

ricardokdz · 2017-05-25T06:53:37Z

@miketamis Does not work for me. How's your directory structure?

prescottprue · 2017-05-25T14:51:48Z

@ricardokdz The directory structure shouldn't be causing any issues. I have been using both the material example and the react-native examples to test.

Can you provide a repo that you are working on to reproduce the issue? For now I am just having to guess at things that might fix the issue.

prescottprue · 2017-05-26T22:29:26Z

@ricardokdz @miketamis @karltaylor What version of webpack are you using? Can you possibly post your webpack.config? If using webpack 2, how do your webpack configs compare to the webpack2 example?

I am able to use v1.5.0-alpha with both webpack 1 and 2 with no issues.

browser field

It has come to my attention though that more often that not (seems like it is happening in your case) bundling libraries end up using the browser field of package.json if it is defined. In the case of react-redux-firebase, that points to the bundled/webpacked version (which may not be what you want if you are also using webpack).

If we can confirm that this is what is happening, I can release 1.5.0-alpha.2 with the only change being removal of the browser field from the package file. That way, only the module version can be loaded (shouldn't cause dependency errors since it is not bundled).

### Description Removed `browser` field from `package.json` in attempt to solve #128 ### Check List - [X] All tests passing - [X] Docs updated with any changes or examples ### Relevant Issues * [#128](https://github.com/prescottprue/react-redux-firebase/issues/#128)

prescottprue · 2017-05-30T21:24:04Z

v.1.5.0-alpha.2 was released without the browser field within package.json. This means that webpack should no longer point to the bundle (but instead the es5ified version).

@ricardokdz @miketamis and @karltaylor Please let me know if any of you get a chance to try this out or can provide a repository where I can reproduce the issue so the fix can be confirmed.

prescottprue · 2017-05-31T07:43:10Z

v1.5.0-beta also does not include the browser field, so it should respond the same way.

stiofand · 2017-10-20T18:14:35Z

I have the same error, im using react-dom 16 and no other library

prescottprue · 2017-10-20T18:40:53Z

@stevematdavies This issue is from a while back and should be solved by being up to date. A few questions would help me get to the bottm of it faster:

What version of react-redux-firebase are you using?
What does your .babelrc look like?
Are you npm linking?
What does your webpack/rollup config look like? (or your build setup if not using one of these)
Have you tried any of the examples or generator-react-firebase?

ghost · 2018-01-12T09:58:28Z

https://webpack.js.org/configuration/externals/

try add prop-types library to external field.

prescottprue · 2018-01-12T10:07:28Z

@imdragonet Do you mean within react-redux-firebase or in an application using it?

From what I thought (could be totally wrong), it was supposed to be a dependency handled by any library using it instead of a peer dependency. Open to doing that though if it some are still seeing this issue.

UbaidAhmedAwan · 2018-07-11T09:06:29Z

Can anyone help me on this?

error: bundling failed: Error: Unable to resolve module ./factoryWithThrowingShims from /Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/react-advanced-form/lib/index.development.js: The module ./factoryWithThrowingShims could not be found from /Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/react-advanced-form/lib/index.development.js. Indeed, none of these files exist:

/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/react-advanced-form/lib/factoryWithThrowingShims(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json)
/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/react-advanced-form/lib/factoryWithThrowingShims/index(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json)
at ModuleResolver.resolveDependency (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:167:697)
at ResolutionRequest.resolveDependency (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:80:16)
at DependencyGraph.resolveDependency (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/node-haste/DependencyGraph.js:237:485)
at Object.resolve (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/lib/transformHelpers.js:116:25)
at dependencies.map.result (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/DeltaBundler/traverseDependencies.js:298:29)
at Array.map ()
at resolveDependencies (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/DeltaBundler/traverseDependencies.js:294:16)
at /Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/DeltaBundler/traverseDependencies.js:159:33
at Generator.next ()
at step (/Users/ubaidahmedawan/Desktop/Tabedaar/tabedaar/node_modules/metro/src/DeltaBundler/traverseDependencies.js:239:307)

prescottprue added the needs-repro label May 11, 2017

prescottprue pushed a commit that referenced this issue May 16, 2017

Switched back to importing PropTypes from react due to (#128)

6ff7f84

prescottprue mentioned this issue May 16, 2017

Version v1.4.0-rc.3 (#128) #134

Merged

1 task

prescottprue added a commit that referenced this issue May 16, 2017

Version v1.4.0-rc.3 (#128) (#134)

b49e98f

* Switched back to importing PropTypes from react due to (#128) * Roadmap updated with population features coming in `v1.5.0`

prescottprue added in-pre-release on-roadmap and removed needs-repro labels May 16, 2017

prescottprue self-assigned this May 16, 2017

prescottprue added this to the v1.4.0 milestone May 16, 2017

prescottprue closed this as completed May 17, 2017

prescottprue reopened this May 24, 2017

prescottprue mentioned this issue May 30, 2017

Version v1.5.0 alpha.2 #146

Merged

2 tasks

prescottprue closed this as completed Jun 21, 2017

ghost mentioned this issue Jan 12, 2018

Cannot resolve dependency './factoryWithThrowingShims' alibaba/BizCharts#99

Closed

kettanaito mentioned this issue Jun 26, 2018

React Native support kettanaito/react-advanced-form#257

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: Cannot find module './factoryWithThrowingShims' from '/app/node_modules/react-redux-firebase/dist' #128

Error: Cannot find module './factoryWithThrowingShims' from '/app/node_modules/react-redux-firebase/dist' #128

karltaylor commented May 10, 2017

prescottprue commented May 10, 2017 •

edited

Loading

danibrear commented May 11, 2017 •

edited

Loading

prescottprue commented May 11, 2017 •

edited

Loading

danibrear commented May 12, 2017

prescottprue commented May 12, 2017

prescottprue commented May 16, 2017 •

edited

Loading

prescottprue commented May 17, 2017 •

edited

Loading

miketamis commented May 24, 2017

prescottprue commented May 24, 2017

prescottprue commented May 24, 2017 •

edited

Loading

ricardokdz commented May 24, 2017

miketamis commented May 24, 2017

prescottprue commented May 25, 2017 •

edited

Loading

ricardokdz commented May 25, 2017

prescottprue commented May 25, 2017

prescottprue commented May 26, 2017

prescottprue commented May 30, 2017

prescottprue commented May 31, 2017 •

edited

Loading

stiofand commented Oct 20, 2017

prescottprue commented Oct 20, 2017

ghost commented Jan 12, 2018

prescottprue commented Jan 12, 2018

UbaidAhmedAwan commented Jul 11, 2018

Error: Cannot find module './factoryWithThrowingShims' from '/app/node_modules/react-redux-firebase/dist' #128

Error: Cannot find module './factoryWithThrowingShims' from '/app/node_modules/react-redux-firebase/dist' #128

Comments

karltaylor commented May 10, 2017

prescottprue commented May 10, 2017 • edited Loading

danibrear commented May 11, 2017 • edited Loading

prescottprue commented May 11, 2017 • edited Loading

danibrear commented May 12, 2017

prescottprue commented May 12, 2017

prescottprue commented May 16, 2017 • edited Loading

prescottprue commented May 17, 2017 • edited Loading

miketamis commented May 24, 2017

prescottprue commented May 24, 2017

prescottprue commented May 24, 2017 • edited Loading

ricardokdz commented May 24, 2017

miketamis commented May 24, 2017

prescottprue commented May 25, 2017 • edited Loading

ricardokdz commented May 25, 2017

prescottprue commented May 25, 2017

prescottprue commented May 26, 2017

browser field

prescottprue commented May 30, 2017

prescottprue commented May 31, 2017 • edited Loading

stiofand commented Oct 20, 2017

prescottprue commented Oct 20, 2017

ghost commented Jan 12, 2018

prescottprue commented Jan 12, 2018

UbaidAhmedAwan commented Jul 11, 2018

prescottprue commented May 10, 2017 •

edited

Loading

danibrear commented May 11, 2017 •

edited

Loading

prescottprue commented May 11, 2017 •

edited

Loading

prescottprue commented May 16, 2017 •

edited

Loading

prescottprue commented May 17, 2017 •

edited

Loading

prescottprue commented May 24, 2017 •

edited

Loading

prescottprue commented May 25, 2017 •

edited

Loading

prescottprue commented May 31, 2017 •

edited

Loading