Do not build SQLAlchemy URI in case the database won't be imported/modified #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Apr 4, 2023
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for the dbt sync the database connection would only be created/updated in Superset in case
--import-dbwas passed. However, the CLI was still building the SQLAlchemy URI regardless of this flag, which would still throw an error in case the DB authentication method in DBT is un-supported in Preset.With this PR,
build_sqlalchemy_params()is only called in caseimport_db == True.