feat(dbt): sync metrics from MetricFlow #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
commented
Jan 8, 2024
| @@ -683,37 +723,46 @@ def get_models(self, job_id: int) -> List[ModelSchema]: | |||
| Fetch all available models. | |||
| """ | |||
| query = """ | |||
| query ($jobId: Int!) { | |||
| models(jobId: $jobId) { | |||
There was a problem hiding this comment.
This is being deprecated, so I converted to the recommended query.
betodealmeida
commented
Jan 8, 2024
| return aliases | ||
|
|
||
|
|
||
| def convert_query_to_projection(sql: str, dialect: MFSQLEngine) -> str: |
There was a problem hiding this comment.
This is the crux of the PR, converting the SQL from MetricFlow into a projection. I've added a good number of unit tests covering all the scenarios I saw.
|
hey @betodealmeida, thank you so much for working on this feature and also adding such extensive test coverage! Are these changes compatible with older versions of dbt Cloud (like 1.4 and 1.5)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an algorithm for syncing dbt metrics defined using MetricFlow. In order to sync metrics it:
Because in MetricFlow metrics are a higher concept, not all metrics can be converted. For example, a metric could be "sales in France", having an implicit
JOINin them. Metrics with joins and/or multiple tables are ignored, and the error is logged.Note that MetricFlow has a concept called "measure" which is much closer to the Superset metric. Unfortunately the GraphQL API doesn't expose all the information we need about measures to convert them into Superset metrics. Namely, the models to which each measure belong are not available via the API.
Testing:
Models and metrics are synced correctly to: https://b5eda41a.us1a.app.preset.io/tablemodelview/list/?pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc