fix(dbt): Support syncing derived metrics on legacy dbt versions #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#254 introduced a new pattern for mapping metrics:
This ended up affecting our ability to parse derived metrics, given the metric macro renders the metric
name
, rather than itsunique_id
. As a consequence, this condition was never met (sincetoken.sql()
would return the macro name):This section of the code is only used by legacy dbt versions -- for new versions we're relying on
MetricFlow
to provide the metric syntax.This PR re-introduces the old mapping structure specifically for this context:
It also includes the
dialect
as part of the metric schema, to assistsqlglot
when parsing the syntax. I was facing an issue when trying to parse below metric syntax since it's BQ-specific: