Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in l() function #258

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Error in l() function #258

wants to merge 1 commit into from

Conversation

moncef-essid
Copy link

Error in l() function

@moncef-essid
Error in l() function
7c3dda3 
Error in l() function
@lmeyer1
Copy link

lmeyer1 commented Jun 25, 2021

Hello, can you please explain ?
I fixed this in #237 the other way around.

'{l s='Sorry, your review appreciation cannot be sent.' d='Modules.Productcomments.Shop' js=1}'; as you suggest does not work if the translated string contains an apostrophe.

'{l|escape:'javascript' s='Sorry, your review appreciation cannot be sent.' d='Modules.Productcomments.Shop'}'; on the other hand correctly escapes apostrophes.

I'm working with PS 1.7.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moncef-essid @lmeyer1