Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new types #59

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Add support for new types #59

merged 1 commit into from
Jul 5, 2016

Conversation

cosinequanon
Copy link
Contributor

@cosinequanon cosinequanon commented Jun 21, 2016

Fixes #56, #60

Tested locally queries, verified from the release notes these are all the types
that were added.

select cast(1 as integer);
select cast(1 as smallint);
select cast(1 as tinyint);
select cast(1 as decimal);

@onurfiliz thoughts on changing tests? I feel like this should just work but you
know the unit tests better than me so I would be happy to update things as you
see fit.

@cosinequanon cosinequanon changed the title Add support for other integer types Add support for other new types Jun 24, 2016
@cosinequanon cosinequanon changed the title Add support for other new types Add support for new types Jun 24, 2016
Fixes #56

Tested locally queries, verified from the release notes these are all the types
that were added.
```
select cast(1 as integer);
select cast(1 as smallint);
select cast(1 as tinyint);
```

@onurfiliz thoughts on changing tests? I feel like this should just work but you
know the unit tests better than me so I would be happy to update things as you
see fit.
@ghost
Copy link

ghost commented Jun 24, 2016

@cosinequanon updated the pull request.

2 similar comments
@ghost
Copy link

ghost commented Jun 24, 2016

@cosinequanon updated the pull request.

@ghost
Copy link

ghost commented Jun 24, 2016

@cosinequanon updated the pull request.

@onurfiliz
Copy link
Contributor

@cosinequanon, I think we need to extend a few test cases to cover these. Feel free to dig those out if you prefer. Otherwise I can extend them later on, we need to do the same for #62 anyhow.

@cosinequanon
Copy link
Contributor Author

I agree about extending the tests. Let's just merge this and #63 and then follow up on the tests. I'm pretty sure this will work and I'd rather have our code not fail when users try the example on our main page which is a bad experience.

@onurfiliz onurfiliz merged commit b79a561 into master Jul 5, 2016
@onurfiliz onurfiliz deleted the int-support branch July 5, 2016 17:47
This was referenced Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants