Generate JS files with Maven build #22645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0edb84c...1d43c61.
|
|
cc @elharo those compiled JS files are removed! |
16 tasks
yhwang
force-pushed
the
integrate-yarn-into-build
branch
from
7d9c892
to
0890673
Compare
|
Just updated the node version to the latest LTS of v18. |
steveburnett
requested changes
May 1, 2024
Compile the JS files with the Maven build and no need to check-in and verify the JS files in a PR. Also update the documents accordingly. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
yhwang
force-pushed
the
integrate-yarn-into-build
branch
from
0890673
to
1d43c61
Compare
|
@steveburnett again thanks for the comments and please review my updates that address your comments. |
steveburnett
approved these changes
May 2, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compile the JS files with the Maven build and no
need to check in and verify the JS files in a PR.
Also, update the documents accordingly and remove
all the compiled JS files.
related: #21062 item 6
Motivation and Context
Checking in the compiled JS files causes confusion and no way to review the change. Integrating
yarnintothe Maven build solves the issue.
Impact
No need to check in the compiled JS files in a PR that changes any of the Presto Console code.
Test Plan
The GH action shall pass without any issues. I also manually built the code and verified the Presto Console worked properly.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.