Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update iceberg procedures according to #22608 #22787

Closed
wants to merge 0 commits into from

Conversation

jackychen718
Copy link
Contributor

According to #22608:
Add subheading Procedures, put Register table, Unregister table, Rollback to snapshots, Expire snapshots under the subheading.

Copy link

linux-foundation-easycla bot commented May 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the docs label May 20, 2024
@tdcmeehan tdcmeehan self-assigned this May 20, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! A few small nits that could be addressed while these topics are being reorganized.

presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Maybe we should use a more specific commit title, something like:

Move the description of Iceberg procedures to a dedicated subheading

@elharo elharo changed the title update iceburg procedures according to #22608 update iceberg procedures according to #22608 May 20, 2024
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local docs build, verified that all requested changes by myself and @ZacBlanco have been made in the current file.

the behavior listed above for the ``DROP TABLE`` command.


Rollback to Snapshots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Rollback to Snapshots
Rollback to Snapshot

Sorry to be pedantic - I think it should match the procedure name

Copy link
Contributor

@steveburnett steveburnett May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is edited, also edit the next line "^^^^^^^^^^^^^^^^^^^^^" to match the length of the characters in the text of this line

@hantangwangd
Copy link
Member

@jackychen718 Thanks for the fix. Please use rebase rather than merge, in that way we can remove the merge commit.

@jackychen718
Copy link
Contributor Author

@hantangwangd Sorry for asking. I see rebase is used to merge an branch without unneccessary commit. Locally, I only have one master branch. After modify the file, could you please give some more guidance how to use rebase in the scenario.Thanks a lot.

@hantangwangd
Copy link
Member

@jackychen718 In order to use rebase, you need a dedicated branch to synchronize with prestodb:master, then rebase your working branch which contains new commits onto it. Let's call these two branches newest and master for example. You can follow the following steps to realize a rebase:

  1. git checkout -B newest // create a new branch newest based on your current working branch

  2. git reset --hard HEAD~2 // hard reset all your own commits, assuming there are 2

  3. git push -f origin newest // push newest to remote repository, use git remote -v to get your remote repository name, assuming the name is origin

  4. Then select branch newest in your own fork repository on github, and click Sync fork -> update branch to synchronize with prestodb:master

  5. git fetch origin -> git rebase origin/newest

In this way, you will rebase you working branch master onto the newest commit list without a merge. Hoping this can help you, any questions please let me know.

@jackychen718
Copy link
Contributor Author

OK. I created another PR as described above with rebase command. Should this PR be closed?

@hantangwangd
Copy link
Member

OK. I created another PR as described above with rebase command. Should this PR be closed?

Sure, you can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants