-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update iceberg procedures according to #22608 #22787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! A few small nits that could be addressed while these topics are being reorganized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Maybe we should use a more specific commit title, something like:
Move the description of Iceberg procedures to a dedicated subheading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, new local docs build, verified that all requested changes by myself and @ZacBlanco have been made in the current file.
the behavior listed above for the ``DROP TABLE`` command. | ||
|
||
|
||
Rollback to Snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rollback to Snapshots | |
Rollback to Snapshot |
Sorry to be pedantic - I think it should match the procedure name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this is edited, also edit the next line "^^^^^^^^^^^^^^^^^^^^^" to match the length of the characters in the text of this line
@jackychen718 Thanks for the fix. Please use rebase rather than merge, in that way we can remove the merge commit. |
@hantangwangd Sorry for asking. I see rebase is used to merge an branch without unneccessary commit. Locally, I only have one master branch. After modify the file, could you please give some more guidance how to use rebase in the scenario.Thanks a lot. |
@jackychen718 In order to use rebase, you need a dedicated branch to synchronize with
In this way, you will rebase you working branch |
OK. I created another PR as described above with rebase command. Should this PR be closed? |
Sure, you can close it. |
According to #22608:
Add subheading Procedures, put Register table, Unregister table, Rollback to snapshots, Expire snapshots under the subheading.