-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sectionful refactor #631
Sectionful refactor #631
Commits on May 25, 2019
-
This splits all of the sections into completely self-contained parts.
Configuration menu - View commit details
-
Copy full SHA for d3b41cd - Browse repository at this point
Copy the full SHA d3b41cdView commit details -
This section was bound together by a single reference from TiffanyFamilyMembers to the end of the bank. Probably caused by the translators.
Configuration menu - View commit details
-
Copy full SHA for 181b4c5 - Browse repository at this point
Copy the full SHA 181b4c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14cae16 - Browse repository at this point
Copy the full SHA 14cae16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b4777e - Browse repository at this point
Copy the full SHA 1b4777eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7001436 - Browse repository at this point
Copy the full SHA 7001436View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0857f70 - Browse repository at this point
Copy the full SHA 0857f70View commit details -
Configuration menu - View commit details
-
Copy full SHA for d014052 - Browse repository at this point
Copy the full SHA d014052View commit details -
Configuration menu - View commit details
-
Copy full SHA for e17aba2 - Browse repository at this point
Copy the full SHA e17aba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e88727 - Browse repository at this point
Copy the full SHA 7e88727View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01f9150 - Browse repository at this point
Copy the full SHA 01f9150View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bc1e17 - Browse repository at this point
Copy the full SHA 0bc1e17View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae1e8bb - Browse repository at this point
Copy the full SHA ae1e8bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 979cca5 - Browse repository at this point
Copy the full SHA 979cca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35fba04 - Browse repository at this point
Copy the full SHA 35fba04View commit details -
Split some questionable things
Want to ask people what the best course of action for these would be.
Configuration menu - View commit details
-
Copy full SHA for 2b8bb5a - Browse repository at this point
Copy the full SHA 2b8bb5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c29a263 - Browse repository at this point
Copy the full SHA c29a263View commit details -
Reorganize INCLUDEs to reduce the amount of top-level files
This will make the `.o` file splitting easier later down the line. Some more splitting is required to finish making main.asm INCLUDE-only, however.
Configuration menu - View commit details
-
Copy full SHA for 973e617 - Browse repository at this point
Copy the full SHA 973e617View commit details -
Restructure the battle animation core file
Moved the core part of anim_commands out to core, and included the entire battle anim engine there.
Configuration menu - View commit details
-
Copy full SHA for 4e77dd3 - Browse repository at this point
Copy the full SHA 4e77dd3View commit details -
This is a rather small and inconsequential part of the (spaghetti) codebase, and I want to move on to the rest of this mess.
Configuration menu - View commit details
-
Copy full SHA for f2c5503 - Browse repository at this point
Copy the full SHA f2c5503View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87552dd - Browse repository at this point
Copy the full SHA 87552ddView commit details -
"split" battle tower map scripts
These can't really be split. The only reason they're being made separate sections is to maintain consistency with the rest of the map scripts.
Configuration menu - View commit details
-
Copy full SHA for 28bf848 - Browse repository at this point
Copy the full SHA 28bf848View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5072712 - Browse repository at this point
Copy the full SHA 5072712View commit details -
Configuration menu - View commit details
-
Copy full SHA for af83b94 - Browse repository at this point
Copy the full SHA af83b94View commit details -
Add constants for BANK[] statements
This will help people move them around, if need be. This should be removed as soon as rgbds supports this.
Configuration menu - View commit details
-
Copy full SHA for c44dc76 - Browse repository at this point
Copy the full SHA c44dc76View commit details -
Do the obvious reorganizations
Things like split some "generic" files into multiple specific files, or some big files into multiple, or join some sections. Thing is, splitting the sections like this gives us great insight into what goes where, and what is or isn't related. This commit doesn't yet throw away strict ROM order, however.
Configuration menu - View commit details
-
Copy full SHA for e57ed43 - Browse repository at this point
Copy the full SHA e57ed43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21a6233 - Browse repository at this point
Copy the full SHA 21a6233View commit details -
ChrisBackpic is split away as well, and it makes sense they're somewhere together.
Configuration menu - View commit details
-
Copy full SHA for 8707481 - Browse repository at this point
Copy the full SHA 8707481View commit details -
Make engine/pokemon/evolve.asm the main file
Data is always secondary, unless independent somehow.
Configuration menu - View commit details
-
Copy full SHA for 4fafcc9 - Browse repository at this point
Copy the full SHA 4fafcc9View commit details -
Split everything into separate
.o
filesThis commit is the start of what I call "the `.o` split". Sadly, this split has made the entire build system _magnitudes_ slower. As such, I will try to make it less slow, and hopefully improve the incremental build times, and later the build time overall. But, if it doesn't work out, this can always be reverted.
Configuration menu - View commit details
-
Copy full SHA for 0072977 - Browse repository at this point
Copy the full SHA 0072977View commit details -
Don't export every single label
Exported all necessary cross-file labels, and unexported the unnecessary exports. This makes the linker much, much faster.
Configuration menu - View commit details
-
Copy full SHA for ba6c472 - Browse repository at this point
Copy the full SHA ba6c472View commit details -
This makes incremental builds really, really fast!
Configuration menu - View commit details
-
Copy full SHA for b57cd1a - Browse repository at this point
Copy the full SHA b57cd1aView commit details -
Add travis support for checking unused globals
This will make sure only necessary symbols are ever exported, except for everything in the ram sections, of course, which doesn't make sense to not be exported. engine/predef.asm and engine/events/specials.asm are ignored because the arrays generate a bunch of symbols that are unused, but we can't really not export some of them since we use a macro.
Configuration menu - View commit details
-
Copy full SHA for 63f6649 - Browse repository at this point
Copy the full SHA 63f6649View commit details -
First draft of optimizing includes
I'm not entirely sure where I'm going with this yet.
Configuration menu - View commit details
-
Copy full SHA for 1000418 - Browse repository at this point
Copy the full SHA 1000418View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b3b79 - Browse repository at this point
Copy the full SHA d5b3b79View commit details -
Create constants/maps_common.inc
This noticeably increases rebuild times by 10 seconds and causes every single map to be rebuilt when certain constants change, even if they're unnecessary, but such is life.
Configuration menu - View commit details
-
Copy full SHA for c6abcec - Browse repository at this point
Copy the full SHA c6abcecView commit details -
Rewrite Makefile to support i18n
This new makefile introduces the following features: - A build/ directory - A version/ directory where all the differences between each version will be kept And this while hopefully keeping all features we used to have.
Configuration menu - View commit details
-
Copy full SHA for af31496 - Browse repository at this point
Copy the full SHA af31496View commit details -
Implement makefile improvements
As suggested by @Rangi42: - Add `tidy` target - Additional comment for the `else` case in the main Makefile - Add `version/crystal.mk` for consistency - Use `.mkdir` as file-creation marker
Configuration menu - View commit details
-
Copy full SHA for 8695545 - Browse repository at this point
Copy the full SHA 8695545View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4126c6 - Browse repository at this point
Copy the full SHA e4126c6View commit details -
- Moved main.asm to gfx/misc.asm - Created constant for the two pics sections - Moved the stadium bins into version/ - Move some graphics rules into gfx/gfx.mk
Configuration menu - View commit details
-
Copy full SHA for fcfb431 - Browse repository at this point
Copy the full SHA fcfb431View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17b07a7 - Browse repository at this point
Copy the full SHA 17b07a7View commit details
Commits on May 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3840b87 - Browse repository at this point
Copy the full SHA 3840b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f2d8f0 - Browse repository at this point
Copy the full SHA 5f2d8f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3948e7 - Browse repository at this point
Copy the full SHA d3948e7View commit details
Commits on May 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7355ec4 - Browse repository at this point
Copy the full SHA 7355ec4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 709087c - Browse repository at this point
Copy the full SHA 709087cView commit details -
With the new Makefile, some changes are required...
Configuration menu - View commit details
-
Copy full SHA for 51cfa80 - Browse repository at this point
Copy the full SHA 51cfa80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3915519 - Browse repository at this point
Copy the full SHA 3915519View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7583b7f - Browse repository at this point
Copy the full SHA 7583b7fView commit details
Commits on May 28, 2019
-
I wonder when we'll just start forcing Mac users to switch to a more recent version of GNU Make. This version is only 5 years younger than the ROM we're reversing...
Configuration menu - View commit details
-
Copy full SHA for f15ad02 - Browse repository at this point
Copy the full SHA f15ad02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 334e46f - Browse repository at this point
Copy the full SHA 334e46fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8ab122 - Browse repository at this point
Copy the full SHA a8ab122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a27be0 - Browse repository at this point
Copy the full SHA 2a27be0View commit details
Commits on May 30, 2019
-
Include some constants inside of maps
floating_constants.inc was moved out of maps_common.inc because it's not something that is necessary for new maps - it's supposed to be the exception, not the norm. Since there's only four maps that use BattleTowerAction, and the battle_tower_constants.inc aren't otherwise used anywhere, they're now only included where required.
Configuration menu - View commit details
-
Copy full SHA for 3b5c710 - Browse repository at this point
Copy the full SHA 3b5c710View commit details
Commits on Jun 1, 2019
-
Forgot to fix TODOs after the fact...
TODO comments are the worst thing invented by mankind, yet I love using them for some reason...
Configuration menu - View commit details
-
Copy full SHA for d35b0a2 - Browse repository at this point
Copy the full SHA d35b0a2View commit details
Commits on Jun 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for bd4abff - Browse repository at this point
Copy the full SHA bd4abffView commit details
Commits on Aug 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0f24d29 - Browse repository at this point
Copy the full SHA 0f24d29View commit details
Commits on Feb 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e16ad2f - Browse repository at this point
Copy the full SHA e16ad2fView commit details -
Remove ASCII-related bank constants
An RGBDS update has made it possible to remove these, by adding proper multicharmap support.
Configuration menu - View commit details
-
Copy full SHA for f3d3376 - Browse repository at this point
Copy the full SHA f3d3376View commit details
Commits on Feb 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1cc46f3 - Browse repository at this point
Copy the full SHA 1cc46f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb0505 - Browse repository at this point
Copy the full SHA ccb0505View commit details
Commits on Feb 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a3d6968 - Browse repository at this point
Copy the full SHA a3d6968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb368a - Browse repository at this point
Copy the full SHA 6eb368aView commit details
Commits on Feb 24, 2020
-
Add documentation for the usage of the new makefile, as I'm sure it'll confuse some people.
Configuration menu - View commit details
-
Copy full SHA for 2761e5a - Browse repository at this point
Copy the full SHA 2761e5aView commit details
Commits on Feb 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d51fd40 - Browse repository at this point
Copy the full SHA d51fd40View commit details
Commits on Feb 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7e5aa33 - Browse repository at this point
Copy the full SHA 7e5aa33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd33d5 - Browse repository at this point
Copy the full SHA 5bd33d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 307e1c7 - Browse repository at this point
Copy the full SHA 307e1c7View commit details -
- Copy the files when running `make` without arguments - Clean topdir files when running `make tidy` - Remove `-march=native` as this doesn't work with `clang`
Configuration menu - View commit details
-
Copy full SHA for ca456b5 - Browse repository at this point
Copy the full SHA ca456b5View commit details -
Remove .asm suffix from every section name
They're arbitrary names, and the .asm part is redundant
Configuration menu - View commit details
-
Copy full SHA for 75e1424 - Browse repository at this point
Copy the full SHA 75e1424View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a910fd - Browse repository at this point
Copy the full SHA 1a910fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for cedf137 - Browse repository at this point
Copy the full SHA cedf137View commit details
Commits on Feb 27, 2020
-
Include data/items/marts in engine/items/mart
Apparently there's a very sneaky non-banked reference between these, that will cause the game to crash if these are not in the same bank.
Configuration menu - View commit details
-
Copy full SHA for 6cc3ca3 - Browse repository at this point
Copy the full SHA 6cc3ca3View commit details -
Unneccessarily "generic" file, also didn't make sense now pokedex_2 is gone.
Configuration menu - View commit details
-
Copy full SHA for 064c721 - Browse repository at this point
Copy the full SHA 064c721View commit details
Commits on Mar 1, 2020
-
These strings are right at the end of generic_callee, but for convenience I'll move them out to a separate file, for now at least.
Configuration menu - View commit details
-
Copy full SHA for 786c3c0 - Browse repository at this point
Copy the full SHA 786c3c0View commit details