Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple independent values in charmap.txt #1276

Open
luckytyphlosion opened this issue Dec 22, 2020 · 1 comment
Open

Multiple independent values in charmap.txt #1276

luckytyphlosion opened this issue Dec 22, 2020 · 1 comment

Comments

@luckytyphlosion
Copy link
Member

Two examples

  • The constant values for sound effects and music are defined independently in charmap.txt and include/constants/songs.h, so for example, changing the value of SE_RAIN in songs.h, or possibly adding a new song won't reflect in the charmap.
  • Placeholder IDs are also defined independently, e.g. STR_VAR_2 is defined as FD 03 in the charmap and also as #define PLACEHOLDER_ID_STRING_VAR_2 0x3 in gflib/text.h. This means changing or adding placeholders requires ensuring that the constant value is exactly the same.
ghoulslash pushed a commit to ghoulslash/pokeemerald that referenced this issue Jan 15, 2021
@ExpoSeed
Merge pull request pret#1276 from LOuroboros/x_items_BE
b166e9a 
Reworked the effects of the X Items #1
ghoulslash pushed a commit to ghoulslash/pokeemerald that referenced this issue Mar 28, 2021
@ExpoSeed
Merge pull request pret#1276 from LOuroboros/x_items_BE
65d0798 
Reworked the effects of the X Items #1
@rawr51919
Copy link
Contributor

Would it make sense for this one to have the charmap.txt depend on songs.h for relevant constants?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luckytyphlosion @rawr51919