Pokemon struct cleanup #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oThis # Conflicts: # src/battle_arcade_game_board.c # src/battle_command.c # src/overlay_94.c # src/scrcmd_move_relearner.c # src/scrcmd_party.c # src/scrcmd_pokemon_misc.c # src/use_item_on_mon.c
red031000
requested changes
May 11, 2023
There was a problem hiding this comment.
generally speaking, I prefer pokemon instead of mon for the variable names, since it's more explicit.
there is a discussion to be had about typedef struct vs explicit struct, I think atm we're leaning towards the latter
The renaming is good though, all caps struct names just seem weird
…sDoThis # Conflicts: # include/field_blackthorn_tutors.h # include/get_egg.h # src/get_egg.c # src/hall_of_fame.c # src/scrcmd_move_relearner.c
|
Solved conflicts. |
red031000
requested changes
May 20, 2023
red031000
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POKEMONtoPokemon.MON_DATAnames.Pokemonpointers.Pokemon.AsparagusEduardo#6051