Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add option for PHP 8.2 #2179

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: add option for PHP 8.2 #2179

merged 1 commit into from
May 22, 2023

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented May 21, 2023

No description provided.

@czosel czosel requested a review from cseufert May 21, 2023 13:55
@czosel czosel mentioned this pull request May 21, 2023
Closed
cseufert
cseufert approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@cseufert cseufert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

however we still do not support DNF syntax for types, eg:

  public function test((A & B) | C $request) {}

probably more of a note for the changelog

@czosel czosel merged commit cce15dd into prettier:main May 22, 2023
@czosel czosel deleted the php-8.2 branch May 22, 2023 13:26
@czosel
Copy link
Collaborator Author

czosel commented May 22, 2023

Released in v0.19.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cseufert cseufert cseufert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czosel @cseufert