Standalone mode

[viceice]

I like to use this plugin in standalone prettier to support formating in monaco editor.

If i try to use this plugin i get webpack compiler errors.

[viceice]

My webpack workaround:

{
  resolve: { alias: { prettier$: require.resolve('prettier/standalone') } }
}

[rart]

I've noticed the same situation. Using it within a react app, compiler outputs:

Compiled with warnings.

./node_modules/prettier/index.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/index.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/index.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/third-party.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/parser-typescript.js
Module not found: Can't resolve '@microsoft/typescript-etw' in '/yada/yada/node_modules/prettier'

Note that in create-react-app, is not possible to configure the webpack aliases unless you eject or use the rewired package so this is important to address via this package itself.

I've submitted a PR which solves this issue.

[kddnewton]

@viceice I'm about to release v0.4.0, once I do could you try again? I want to fully understand this issue

[thorn0]

Would it help if Prettier added the browser property to its package.json pointing to standalone.js?

[kddnewton]

If you edit it in your node_modules and rebuild does that fix it?

On Tue, Jan 21, 2020 at 9:05 AM Georgii Dolzhykov ***@***.***> wrote: Would it help if Prettier added the browser field to its package.json pointing to standalone.js? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28?email_source=notifications&email_token=ABG3P3UB24442HC2FWLUXH3Q636LTA5CNFSM4J2CAQBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJP3B4Q#issuecomment-576696562>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG3P3ROP6CIVFCDQ3D2WALQ636LTANCNFSM4J2CAQBA> .

-- *Kevin D. Deisz* CTO, CultureHQ <https://www.culturehq.com>

[viceice]

@viceice I'm about to release v0.4.0, once I do could you try again? I want to fully understand this issue

Yes, but earliest on next week. But our ci will get the update as you publish it. So I can check the result.

[kddnewton]

Does #55 solve this issue?

[rart]

@kddeisz, It does.

[kddnewton]

Nice - I've release v0.7.1 with the change. Going to optimistically close this. Feel free to reopen if it's still an issue.