Feat: now have 103 and 426 http-codes #89
Conversation
|
@prettymuchbryce please kindly review this PR. :) |
because the docs will be generated, we don't need to add it manually.
|
@prettymuchbryce is there anything i need to changes or fix? |
There was a problem hiding this comment.
@angellee177 map this issue ( #20 ) to this pull request so that it'll be closed as soon as this pull request is merged.
also everything looks good @prettymuchbryce it can be merged.
|
thank you for reviewing my PR @pacifiquem :) can you help me to merge the PR? |
|
No @angelsupp we've to wait for @prettymuchbryce or any other maintainer to merge it. Since everything looks good let's hope they'll merge it soon :). |
|
thanks a lot @pacifiquem 😆 |
|
Thank you and apologies for my delayed response. It looks like HTTP 521 is not an official status code, but instead is specific to CloudFlare. The documentation linked in this PR here is for an unrelated SMTP (not HTTP) error. I would prefer not to include codes without an official RFC. If we can remove HTTP 521 from this PR then I will happily merge the PR as 103 and 426 look good to me! |
There was a problem hiding this comment.
@angellee177 @angelsupp remove 521 status code as suggested by @prettymuchbryce and this PR will be merged.
|
Closes #20 |
|
let me remove the 521 status code @pacifiquem @prettymuchbryce |
|
done @prettymuchbryce @pacifiquem 😆 |
|
@prettymuchbryce let's merge it. |
|
Thank you @angelsupp for your contribution. |
fix issue for this ticket https://github.com/prettymuchbryce/http-status-codes/issues/20