Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store modules in pride-local config #82

Closed
lptr opened this issue Jul 28, 2014 · 4 comments
Closed

Store modules in pride-local config #82

lptr opened this issue Jul 28, 2014 · 4 comments
Milestone

Comments

@lptr
Copy link
Contributor

lptr commented Jul 28, 2014

Instead of having a separate .pride/modules file, the list of current modules should be stored in .pride/config.

This would allow the developer to share this single file with others, who could re-create the same pride for themselves. (See #81)

Modules could be stored like this:

modules.0.name = boxfish-geometry
modules.0.url = https://github.com/prezi/boxfish-geometry
modules.0.vcs = git
@lptr
Copy link
Contributor Author

lptr commented Jul 28, 2014

Or it could look like this:

modules.boxfish-geometry.url = https://github.com/prezi/boxfish-geometry
modules.boxfish-geometry.vcs = git

@lptr
Copy link
Contributor Author

lptr commented Jul 28, 2014

However, with the latter there is no option to have, say, . in the module name, which might be overly limiting (think of typical Eclipse project names that include the package name in the project name).

@lptr
Copy link
Contributor Author

lptr commented Jul 28, 2014

Actually, that's not true: Commons Configurations will escape the key, so we can use the second format.

lptr added a commit that referenced this issue Jul 28, 2014
lptr added a commit that referenced this issue Jul 29, 2014
@lptr lptr added this to the 0.7.5 milestone Jul 29, 2014
@lptr
Copy link
Contributor Author

lptr commented Jul 29, 2014

This should be done now.

@lptr lptr closed this as completed Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant