Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qualified ID #130

Closed
wants to merge 1 commit into from
Closed

Use qualified ID #130

wants to merge 1 commit into from

Conversation

punya
Copy link
Contributor

@punya punya commented Jan 14, 2015

Required for #129 (step 1 from https://plugins.gradle.org/submit).

@lptr
Copy link
Contributor

lptr commented Jan 14, 2015

Two things:

  • we need to keep the old pride identifier as well for backwards compatibility (it is actually suggested by Gradle to do it like that somewhere, IIRC)
  • the group name of the project is com.prezi.gradle.pride, I think the plugin's ID should match that. I'm not against changing to group name to com.prezi.pride, as the gradle part is not really clarifying anything, but it needs to be done at the same time.

@@ -0,0 +1 @@
implementation-class=com.prezi.gradle.pride.PridePlugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be without gradle as well, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the group ID and the plugin ID, but not the package prefix. I can do that too, if you'd like (though it's not strictly necessary).

@lptr lptr added the wontfix label Jan 16, 2015
@lptr lptr added this to the 0.10 milestone Jan 16, 2015
@lptr
Copy link
Contributor

lptr commented Jan 16, 2015

Already fixed in master.

@lptr lptr closed this Jan 16, 2015
@punya punya deleted the feature/plugins.gradle.org branch April 22, 2015 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants