[NAYB-148] feat : 상품에 대한 리뷰 생성 시 Redis에 있는 평균 별점을 갱신한다. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjo6300
requested review from
pushedrumex,
funnysunny08,
seongHyun-Min,
Seongju-Lee and
hseong3243
as code owners
…4-NaBMart into feature/NAYB-148
Test Results352 tests +1 352 ✔️ +1 9s ⏱️ -1s Results for commit c1b6ed5. ± Comparison against base commit 99c96a9. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
hseong3243
approved these changes
Sep 16, 2023
| ) { | ||
| this.reviewRepository = reviewRepository; | ||
| this.numberOfReviewsRedisTemplate = numberOfReviewsRedisTemplate; | ||
| this.listOperations = rateRedisTemplate.opsForList(); |
There was a problem hiding this comment.
bean으로 등록한 listOperations와 동일하다면 reidsTemplate을 주입 받지 말고 listOperations를 직접 주입받아도 될 것 같아요! 혹시 동일한 객체인가요?
| private static final String REVIEW_COUNT_CACHE_KEY = "reviewCount_Item_"; | ||
| private static final String AVERAGE_RATE_CACHE_KEY = "averageRate_Item_"; | ||
| private static final String REVIEW_COUNT_CACHE_KEY = "reviewCount:Item:"; | ||
| private static final String AVERAGE_RATE_CACHE_KEY = "averageRating:Item:"; |
There was a problem hiding this comment.
키값을 바꾸신 이유는 무엇인가요! 궁금합니다!
There was a problem hiding this comment.
레디스의 어노테이션을 이용해 변수명이 자동으로 지어질 때 저런 규칙으로 되더라구요! 그래서 변경했습니다 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
📝 작업 요약
💡 관련 이슈
NAYB-148