Swagger 리펙토링(도메인 및 Controller 등)/#118

[jay-so]

👨‍💻 작업 사항

**이슈 #118 **

📑 PR 개요

• 프로그램 내 Swagger 리팩토링 과정입니다.

---

✅ 작업 목록

• 도메인 별 DTO에 Swagger 적용
• AutoController
• CustomerController
• SellerController
• PerformanceController
• RankingController
• ScheduleController
• ApiResponse 클래스 명 -> ApiResponseType 클래스로 클래스 명 변경
  (Swagger 파일 내에서 SpringBoot의 ApiResponse와 작성한 ApiResponsee 인식 충돌이 나 ApiResponseType으로 변경)

---

🙏 리뷰어에게

• 설명1
• 설명2

---

기타

---

Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

• P1: 꼭 반영해주세요 (Request changes)
• P2: 적극적으로 고려해주세요 (Request changes)
• P3: 웬만하면 반영해 주세요 (Comment)
• P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
• P5: 그냥 사소한 의견입니다 (Approve)

[github-actions]

Test Results

16 files  ±0  16 suites  ±0   24s ⏱️ +3s
61 tests ±0  61 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
69 runs  ±0  69 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit deb4069. ± Comparison against base commit 0fb9b6e.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.

com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [1] reservation=com.programmers.ticketparis.reservation.domain.Reservation@d7fa9bb
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [2] reservation=com.programmers.ticketparis.reservation.domain.Reservation@2f81dbf6
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [1] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@6d1e60b7
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [2] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@7bd73f42

com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [1] reservation=com.programmers.ticketparis.reservation.domain.Reservation@29240ac7
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [2] reservation=com.programmers.ticketparis.reservation.domain.Reservation@6adf3c1f
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [1] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@d58fa2
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [2] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@7e965590

[github-actions]

Test Coverage Report

Overall Project	66.01% -0.97%	🍏
Files changed	60%	🍏

File	Coverage
ReservationController.java	100%	🍏
ScheduleCreateRequest.java	100%	🍏
PerformanceUpdateRequest.java	100%	🍏
LoginSuccessResponse.java	100%	🍏
LoginRequest.java	100%	🍏
PerformanceController.java	100%	🍏
ScheduleController.java	100%	🍏
ReservationCreateRequest.java	90%	🍏
PerformanceCreateRequest.java	89.09%	🍏
PerformanceResponse.java	87.96%	🍏
ScheduleResponse.java	86.61%	🍏
PerformanceIdResponse.java	82.35% -17.65%	❌
ScheduleIdResponse.java	82.35% -17.65%	❌
ReservationIdResponse.java	82.35% -17.65%	❌
ApiResponseType.java	80.6% -19.4%	🍏
AuthController.java	75%	🍏
SessionValueDto.java	71.43%	🍏
ReservationResponse.java	66.67%	🍏
RankingController.java	60%	🍏
ResponseWrapper.java	50% -7.14%	🍏
SellerController.java	37.5%	🍏
CustomerController.java	37.5%	🍏
RankingResponse.java	0%	🍏
ExceptionHandlerFilter.java	0% -20%	❌
SellerCreateRequest.java	0%	🍏
CustomerCreateRequest.java	0%	🍏
LogoutSuccessResponse.java	0% -44.44%	❌
CustomerResponse.java	0%	🍏
CustomerIdResponse.java	0% -17.65%	❌
SellerResponse.java	0%	🍏
SellerIdResponse.java	0%	🍏

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

63.6% Coverage
7.5% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

• SoarCloud 내 ticketParis 전체 코드의 중복 코드 60%로 설정을 조건으로 했으나, 이전 80% 설정 조건이 적용되어 Fail부분이 발생함
• 확인 후, 해당 설정 부분 재 수정함