Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separator: Deprecate #12080

Closed
ritonglue opened this issue Jun 6, 2024 · 5 comments · Fixed by #12081
Closed

Separator: Deprecate #12080

ritonglue opened this issue Jun 6, 2024 · 5 comments · Fixed by #12081
Assignees
@melloware
Labels
breaking-change Change is not backwards compatible
Milestone
15.0.0

Comments

@ritonglue
Copy link

Describe the bug

If you try to search separator nothing comes out.
If you scroll down up to the "Misc" group, you can't find "separator".

But I found it !
https://www.primefaces.org/showcase/ui/misc/separator.xhtml?

Reproducer

Just try to search the separator in the showcase.

Expected behavior

After typing "separator" in the search field, it must come out.

PrimeFaces edition

None

PrimeFaces version

14.0.0-SNAPSHOT

Theme

No response

JSF implementation

All

JSF version

2.3

Java version

17

Browser(s)

No response
@ritonglue ritonglue added ‼️ needs-triage Issue needs triaging 🐞 defect Bug...Something isn't working labels Jun 6, 2024
@melloware
Copy link
Member

Separator was replaced by Divider: https://www.primefaces.org/showcase/ui/panel/divider.xhtml?jfwid=92c05

It was left in for backwards compatability for those still using it but the showcase example removed from the menu so people would stop using it.

@melloware melloware changed the title primefaces showcase : is separator an easter egg ? Separator: Deprecate Jun 6, 2024
@melloware melloware added breaking-change Change is not backwards compatible and removed 🐞 defect Bug...Something isn't working ‼️ needs-triage Issue needs triaging labels Jun 6, 2024
melloware added a commit to melloware/primefaces that referenced this issue Jun 6, 2024
@melloware
Fix primefaces#12080: Separator deprecated
9c536e2
@melloware melloware mentioned this issue Jun 6, 2024
Merged
@melloware melloware added this to the 15.0.0 milestone Jun 6, 2024
@melloware melloware self-assigned this Jun 6, 2024
@ritonglue
Copy link
Author

I see. It would be interesting to make it appear just like "bar", with a "Deprecated" label :
https://www.primefaces.org/showcase/ui/chartjs/bar/bar.xhtml

@melloware
Copy link
Member

Yep I can do that too.

melloware added a commit to melloware/primefaces that referenced this issue Jun 7, 2024
@melloware
Fix primefaces#12080: Separator deprecated
a9b0d7a
@melloware
Copy link
Member

image

@ritonglue
Copy link
Author

Nice

melloware added a commit to melloware/primefaces that referenced this issue Jun 10, 2024
@melloware
Fix primefaces#12080: Separator deprecated
df214ec
melloware added a commit that referenced this issue Jun 10, 2024
@melloware
Fix #12080: Separator deprecated (#12081)
127424f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
breaking-change Change is not backwards compatible
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

Fix #12080: Separator deprecated melloware/primefaces
2 participants
@melloware @ritonglue