Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix primefaces#12011: align contextmenu properly when body is scrolled #12012

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix primefaces#12011: align contextmenu properly when body is scrolled #12012

merged 1 commit into from
Nov 15, 2022

Conversation

Hapcy
Copy link

@Hapcy Hapcy commented Oct 5, 2022

Fixes #12011 .

@Hapcy
Copy link
Author

Hapcy commented Oct 5, 2022

I changed document.body.scrollLeft and document.body.scrollTop to document.scrollingElement.scrollLeft and document.scrollingElement.scrollTop respectively because these fields on document.body are always 0.

@cetincakiroglu
Copy link
Contributor

Hi @Hapcy,

Good catch, thanks for your effort and support!

@cetincakiroglu cetincakiroglu merged commit 2164e70 into primefaces:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: ContextMenu is not aligned properly when the document is scrolled
2 participants
@Hapcy @cetincakiroglu