Fixed #12706 - Added isPlaying method and fixed autoplay behaviour #12730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
volvachev
reviewed
Mar 11, 2023
| } | ||
| } | ||
|
|
||
| isPlaying(){ | ||
| return this.interval; |
There was a problem hiding this comment.
Hi, can you convert to boolean, because now it is a number or undefined, for understanding is not clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge requests add the isPlaying Method to the carousel and sets interval 100% to undefined when stopping carousel. Also when restarting the carousel or stopping it from other points outside the dots or pagings, the carousel had a broken behaviour due to wrong allowAutoplay States. Here the allowAutoplay states are now handled in these functions and so have always a correct autoplay behaviour.