You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose of this PR - fix an issue with the drag of the dialog component when vertical or horizontal margins was applied to the p-dialog component. If the user adds a margin to the Dialog component will have unexpected behaviour during the dragging process. When the user tries to drag the popup to the left, it moves to the right.
Current behaviour
first-1_vQ5eaKWM.mp4
Behavior after the fix
second-2_EjrfYrzf.mp4
Also in scope of this PR were solved problems with types assertion in code
This issue linked to the fixes for PrimeVue and PrimeReact
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect Fixes
fix #13493
The main purpose of this PR - fix an issue with the drag of the dialog component when vertical or horizontal margins was applied to the
p-dialogcomponent. If the user adds a margin to the Dialog component will have unexpected behaviour during the dragging process. When the user tries to drag the popup to the left, it moves to the right.Current behaviour
first-1_vQ5eaKWM.mp4
Behavior after the fix
second-2_EjrfYrzf.mp4
Also in scope of this PR were solved problems with types assertion in code
This issue linked to the fixes for PrimeVue and PrimeReact