Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextMenu: Submenu overflowing the page #2318

Closed
VsevolodGolovanov opened this issue Sep 23, 2021 · 1 comment · Fixed by #3719
Closed

ContextMenu: Submenu overflowing the page #2318

VsevolodGolovanov opened this issue Sep 23, 2021 · 1 comment · Fixed by #3719
Assignees
@melloware
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.7.3

Comments

@VsevolodGolovanov
Copy link

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/primereact-menu-overflowing-qer9w

Current behavior
A long menu overflows the page:
image

Expected behavior
A menu should prefer to stay in the viewport, abandoning its source. Like PrimeFaces does:
image

Minimal reproduction of the problem with instructions
Open the linked codesandbox.
Right click the button.
Hover the "Submenu".
See how the next menu level overflows the page.

Please tell us about your environment:

  • React version:
    17.0.2

  • PrimeReact version:
    6.5.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@VsevolodGolovanov
Copy link
Author

VsevolodGolovanov commented Sep 23, 2021 •
edited
Loading

You don't necessarily need a long menu even, you can just open it close to the bottom of the page:
image

@VsevolodGolovanov VsevolodGolovanov changed the title Menu overflowing the page Submenu overflowing the page Sep 24, 2021
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 6, 2021
@mertsincan mertsincan self-assigned this Nov 6, 2021
@melloware melloware changed the title Submenu overflowing the page ContenMenu: Submenu overflowing the page Nov 29, 2022
melloware added a commit to melloware/primereact that referenced this issue Nov 29, 2022
@melloware
Fix primefaces#2318: ContextMenu submenu collision detection
5146750
@melloware melloware assigned melloware and unassigned mertsincan Nov 29, 2022
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 29, 2022
@melloware melloware added this to the 8.7.3 milestone Nov 29, 2022
@melloware melloware mentioned this issue Nov 29, 2022
Merged
@melloware melloware changed the title ContenMenu: Submenu overflowing the page ContextMenu: Submenu overflowing the page Nov 29, 2022
melloware added a commit that referenced this issue Nov 29, 2022
@melloware
Fix #2318: ContextMenu submenu collision detection (#3719)
ae07764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.7.3
Development

Successfully merging a pull request may close this issue.

Fix #2318: ContextMenu submenu collision detection melloware/primereact
3 participants
@melloware @VsevolodGolovanov @mertsincan