Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: keyboard navigation doesn't work on dropdown with groups #6124

Closed
hitosu opened this issue Mar 9, 2024 · 2 comments · Fixed by #6430 or leoo1992/GeradorQRCode#23
Closed

Dropdown: keyboard navigation doesn't work on dropdown with groups #6124

hitosu opened this issue Mar 9, 2024 · 2 comments · Fixed by #6430 or leoo1992/GeradorQRCode#23
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA

Comments

@hitosu
Copy link

hitosu commented Mar 9, 2024

Describe the bug

Keyboard navigation doesn't work on Dropdown with groups because findNextOptionIndex and findPrevOptionIndex uses top level of visibleOptions array to find next / prev position but in case of groups that array consists of group items and actual items are inside items property.

Reproducer

https://primereact.org/dropdown/#group

PrimeReact version

10.5.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Open Dropdown with groups
  2. Try to keyboard navigate with arrows

Expected behavior

findNextOptionIndex and findPrevOptionIndex should look into items property for actual items.
@hitosu hitosu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 9, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 9, 2024
@KirilCycle
Copy link
Contributor

@melloware Hello! Can i take this ?

@melloware
Copy link
Member

sure!

@KirilCycle KirilCycle mentioned this issue Apr 20, 2024
Merged
nitrogenous added a commit that referenced this issue Apr 29, 2024
@nitrogenous
Merge pull request #6430 from KirilCycle/fix/drop-down-menu-navigation
b5ed11d 
Fix #6124 : Dropdown navigation like PrimeVue
@KirilCycle KirilCycle mentioned this issue May 3, 2024
Closed
@Rekl0w Rekl0w mentioned this issue May 5, 2024
Closed
@leoo1992 leoo1992 mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
No milestone
3 participants
@hitosu @melloware @KirilCycle