Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight range of year in datePicker #6760

Merged

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Jun 14, 2024

Describe the bug

fix #6653

Context: When the selectionMode of the datapicker is set to range and the view is set to year:

  • There is an issue where the years within the selected start and end range are not being highlighted.
2024-06-14.3.56.07.mov

Reproducer

https://stackblitz.com/edit/hyhoxe-ttg6dh?file=src%2FApp.jsx


Expected behavior

current expect
스크린샷 2024-06-14 오후 3 54 42 스크린샷 2024-06-14 오후 3 54 21

How to resolve

  • To resolve this, the condition for highlighting years has been modified.

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 6:57am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 6:57am

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Jun 14, 2024
@melloware melloware merged commit 2a8001f into primefaces:master Jun 14, 2024
6 of 7 checks passed
@melloware melloware self-requested a review June 14, 2024 12:32
@KumJungMin KumJungMin deleted the fix/calendar-range-year-mode branch June 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar: Incorrect styling when selecting month/year range
2 participants