Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Allow custom icons #3054

Closed
Magiczne opened this issue Sep 29, 2022 · 2 comments · Fixed by #3055
Closed

Dialog: Allow custom icons #3054

Magiczne opened this issue Sep 29, 2022 · 2 comments · Fixed by #3055
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.18.1

Comments

@Magiczne
Copy link
Contributor

Describe the feature you would like to see added

Extracted from #2979 - adding custom icons support for dialog component

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response
@Magiczne Magiczne added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 29, 2022
This was referenced Sep 29, 2022
Closed
Merged
@tugcekucukoglu tugcekucukoglu added this to the 3.18.1 milestone Oct 28, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Oct 28, 2022
@tugcekucukoglu
Copy link
Member

If you are still interested, maximize and minimize icons do not have icon props. https://github.com/primefaces/primevue/blob/master/src/components/dialog/Dialog.vue#L401

Thanks for your contribution.

@Magiczne
Copy link
Contributor Author

@tugcekucukoglu sure. Will do it

@Magiczne Magiczne mentioned this issue Oct 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.18.1
Development

Successfully merging a pull request may close this issue.

Add custom icons support for the Dialog component Magiczne/primevue
2 participants
@Magiczne @tugcekucukoglu