Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlaypanel: Overlaypanel closes when any key is pressed #4712

Closed
kadirboylu opened this issue Oct 29, 2023 · 0 comments · Fixed by #4713
Closed

Overlaypanel: Overlaypanel closes when any key is pressed #4712

kadirboylu opened this issue Oct 29, 2023 · 0 comments · Fixed by #4713
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.39.0

Comments

@kadirboylu
Copy link
Contributor

Describe the bug

If the closeOnEscape prop is true (this is the default behavior), the overlaypanel should only be closed when the escape key is pressed. There is a bug here, the overlaypanel closes when any key is pressed.

Reproducer

https://primevue.org/overlaypanel/

PrimeVue version

3.38.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to Overlay panel.
  2. Click on Show button, an overlay pops up.
  3. Click any key. Overlay will be closed.

Expected behavior

Overlay should close on only escape key press.
@kadirboylu kadirboylu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 29, 2023
kadirboylu added a commit to kadirboylu/primevue that referenced this issue Oct 29, 2023
@kadirboylu
fix: overlaypanel only be closed on escape key pressed
851103f 
primefaces#4712
primefaces#4712
@kadirboylu kadirboylu mentioned this issue Oct 29, 2023
Merged
kadirboylu added a commit to kadirboylu/primevue that referenced this issue Oct 30, 2023
@kadirboylu
fix: add closeOnEscape for onContentKeydown
5e1e7da 
primefaces#4712
primefaces#4712
tugcekucukoglu added a commit that referenced this issue Oct 31, 2023
@tugcekucukoglu
Merge pull request #4713 from kadirboylu/master
6f342ad 
Fix #4712 Overlaypanel: Overlaypanel closes when any key is pressed
@tugcekucukoglu tugcekucukoglu mentioned this issue Oct 31, 2023
Closed
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 31, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.38.2 milestone Oct 31, 2023
@tugcekucukoglu tugcekucukoglu mentioned this issue Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.39.0
Development

Successfully merging a pull request may close this issue.

Fix #4712 Overlaypanel: Overlaypanel closes when any key is pressed kadirboylu/primevue
2 participants
@tugcekucukoglu @kadirboylu