Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseIcon: SpinnerIcon component isn't spinning. #4791

Closed
demershov opened this issue Nov 9, 2023 · 0 comments · Fixed by #4792
Closed

BaseIcon: SpinnerIcon component isn't spinning. #4791

demershov opened this issue Nov 9, 2023 · 0 comments · Fixed by #4792
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.41.0

Comments

@demershov
Copy link
Contributor

demershov commented Nov 9, 2023 •
edited
Loading

Describe the bug

Hi guys,

Starting from version 3.36.0 when #4530 issues was closed, the SpinnerIcon component broke down in all components where it's used. This is because the styles are from BaseIconStyle.js aren't inserted into the build project.
You can see this also on the library page - https://primevue.org/multiselect/#loadingstate (No spinning).

As a quick solution option: If BaseIcon.vue will be expanded from BaseComponent, then everything will work.

Thanks.

Reproducer

https://codesandbox.io/p/sandbox/nostalgic-khorana-zfmhc8

PrimeVue version

3.40.1

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@demershov demershov added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 9, 2023
demershov added a commit to demershov/primevue that referenced this issue Nov 9, 2023
@demershov
Fix primefaces#4791 - SpinnerIcon: SpinnerIcon component isn't spinning
7e8a471
@demershov demershov changed the title BaseIcon: The SpinnerIcon component isn't spinning. BaseIcon: SpinnerIcon component isn't spinning. Nov 9, 2023
@demershov demershov mentioned this issue Nov 9, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 15, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.41.0 milestone Nov 15, 2023
tugcekucukoglu added a commit that referenced this issue Nov 15, 2023
@tugcekucukoglu
Merge pull request #4792 from demershov/master
007865a 
Fix #4791 - BaseIcon: SpinnerIcon component isn't spinning.
@tugcekucukoglu tugcekucukoglu mentioned this issue Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.41.0
Development

Successfully merging a pull request may close this issue.

Fix #4791 - BaseIcon: SpinnerIcon component isn't spinning. demershov/primevue
2 participants
@demershov @tugcekucukoglu