Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'filter'-event to Tree.vue #4874

Conversation

mroettgen
Copy link
Contributor

@mroettgen mroettgen commented Nov 23, 2023

Fix #4876

Feature Request

To control the expandedKeys after the user updates their filter-input, it is needed to notify the parent component of this update.

This PR suggests adopting the same filter event that is present on similar components.

I also fixed a jsdoc missmatch in Tree.d.ts:442

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 3:56pm

@tugcekucukoglu
Copy link
Member

Could you create an issue?

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 24, 2023
@mroettgen
Copy link
Contributor Author

Could you create an issue?

Sure thing, the issue is now referenced in the PR description

@tugcekucukoglu tugcekucukoglu merged commit 31cb589 into primefaces:master Dec 1, 2023
2 of 4 checks passed
@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Dec 1, 2023
@mroettgen mroettgen deleted the features/mroettgen/tree-add-search-event branch December 4, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree: Missing 'filter' event on search
2 participants